Paths and additional commands for cleanup

[Joseph Kern]

Chapter 5 Section 1: Binutils Pass 1 has a parts that are ambiguous this patch attempts to address these issues.

There is a comment in Chapter 3 stating the following:

"A working directory is also required to unpack the sources and build them. $LFS/sources can be used both as the place to store the tarballs and patches and as a working directory. "

But none of the paths reflect this statement. In some cases they read ../ where they should read ../sources/ it looks like there may be more patches like this that are needed. I will keyword them with 'sources_path' in the future.

I've also added cleanup instructions, it is stated earlier that you should remove the source and build directory contents before moving on, showing an example here would be beneficial.

Thirdly, I've added an explicit tar command and directory path $LFS/sources to ensure proper unpacking and directory context. Patch is attached.

[Joseph Kern]

Built with svn diff

[DJ Lucas]

Replying to josephkern:

Chapter 5 Section 1: Binutils Pass 1 has a parts that are ambiguous this patch attempts to address these issues.

There is a comment in Chapter 3 stating the following:

"A working directory is also required to unpack the sources and build them. $LFS/sources can be used both as the place to store the tarballs and patches and as a working directory. "

But none of the paths reflect this statement. In some cases they read ../ where they should read ../sources/ it looks like there may be more patches like this that are needed. I will keyword them with 'sources_path' in the future.

Actually, you've simply overlooked a rather important note regarding the build procedure. As outlined in Section 5.3, in the third "Important" box on that page, the starting point for all commands is in the newly created directory (after unpacking the source tarball). It is an editor's unwritten rule that only in special cases, a tar command be placed into the book's instructions. AFAIK, the only exception is GMP and MPFR in GCC. This rule is in place to avoid too much hand-holding for newer users that probably don't quite have the requisite knowledge to successfully complete a build.

This ticket should be closed invalid IMO, but can stay open for a day or so if you have a suggestion to make that less ambiguous as it _has_ come up a couple of times over the years. It is usually just the result of the reporter being a little too eager and skimming over the instructions so that they can get right into his/her first LFS. :-)

Hope that helps. Have fun.

[Joseph Kern]

Do'h.

I've been assuming this meant to do it ABOVE the sources dir ... I was wondering how so many paths could be wrong.

I misread this line: "The Binutils documentation recommends building Binutils outside of the source directory in a dedicated build directory:"

I took this to mean the sources directory, not the binutils source directory. What about the wording: "The Binutils documentation recommends building Binutils outside of it's own source directory in a dedicated build directory:"

[Joseph Kern]

*ahem* its not it's

"The Binutils documentation recommends building Binutils outside of its own source directory in a dedicated build directory:"

... I need more coffee.

Replying to josephkern:

Do'h.

I've been assuming this meant to do it ABOVE the sources dir ... I was wondering how so many paths could be wrong.

I misread this line: "The Binutils documentation recommends building Binutils outside of the source directory in a dedicated build directory:"

I took this to mean the sources directory, not the binutils source directory. What about the wording: "The Binutils documentation recommends building Binutils outside of it's own source directory in a dedicated build directory:"

[bdubbs@…]

The patch recommends building in the wrong location. The build directory is not deleted and the instructions are redundant.