Opened 6 weeks ago
Closed 5 weeks ago
#5653 closed enhancement (invalid)
alignment/blocking - LFS r12.2-107-systemd
Reported by: | rhubarbpieguy | Owned by: | lfs-book |
---|---|---|---|
Priority: | normal | Milestone: | 12.4 |
Component: | Book | Version: | git |
Severity: | normal | Keywords: | |
Cc: |
Description
A minor point, but the following in 8.58 Coreutils-9.6 seems to differ from blocking/alignment in other packages. autoreconf -fv automake -af Should it be changed to: autoreconf -fv automake -af The change would be in line with other alignments such as: mkdir build cd build
Change History (3)
comment:1 by , 6 weeks ago
comment:2 by , 6 weeks ago
Regardless of the release managing I don't think the request is valid. For "mkdir build; cd build" we align it because both the parameters are "build". But for this case I cannot see an relation between the parameters.
So would we start to rewrite things like
cd .. cat gcc/limitx.h gcc/glimits.h gcc/limity.h > \ `dirname $($LFS_TGT-gcc -print-libgcc-file-name)`/include/limits.h
to
cd .. cat gcc/limitx.h gcc/glimits.h gcc/limity.h > \ `dirname $($LFS_TGT-gcc -print-libgcc-file-name)`/include/limits.h
or
make install for target in depmod insmod modinfo modprobe rmmod; do ln -sfv ../bin/kmod /usr/sbin/$target rm -fv /usr/bin/$target done
to
make install for target in depmod insmod modinfo modprobe rmmod; do ln -sfv ../bin/kmod /usr/sbin/$target rm -fv /usr/bin/$target done
??? I.e. if we consider this a "different" alignment we'd have "different" alignments everywhere. So "fixing" this just does not make sense to me.
Note:
See TracTickets
for help on using tickets.
Sure, that's OK. It does not affect the execution of the commands.